Skip to content

igraph update #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed

igraph update #4289

wants to merge 36 commits into from

Conversation

LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Jul 20, 2023

To close #4285

Documentation PR

  • I've seen the doc/README.md file
  • This change runs in the current version of Plotly on PyPI and targets the doc-prod branch OR it targets the master branch
  • If this PR modifies the first example in a page or adds a new one, it is a px example if at all possible
  • Every new/modified example has a descriptive title and motivating sentence or paragraph
  • Every new/modified example is independently runnable
  • Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized
  • Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible
  • The random seed is set if using randomly-generated data in new/modified examples
  • New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets
  • Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations
  • Imports are plotly.graph_objects as go / plotly.express as px / plotly.io as pio
  • Data frames are always called df
  • fig = <something> call is high up in each new/modified example (either px.<something> or make_subplots or go.Figure)
  • Liberal use is made of fig.add_* and fig.update_* rather than go.Figure(data=..., layout=...) in every new/modified example
  • Specific adders and updaters like fig.add_shape and fig.update_xaxes are used instead of big fig.update_layout calls in every new/modified example
  • fig.show() is at the end of each new/modified example
  • plotly.plot() and plotly.iplot() are not used in any new/modified example
  • Hex codes for colors are not used in any new/modified example in favour of these nice ones

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

-->

shaido987 and others added 30 commits September 9, 2021 16:34
Diamond is mentioned twice in the basic symbol list.
Fixed the world's smallest typo in the doc file for figure factory.
Merge master back in to doc-prod to deploy updated docs
…atch

Doc - Configuration-options - improvement propositions
Fixed a typo in figure-factory-subplots.md
Fix minor typo in marker-style.md
@LiamConnors LiamConnors changed the base branch from master to doc-prod July 20, 2023 15:34
@LiamConnors LiamConnors changed the title Igraph update igraph update Jul 20, 2023
@alexcjohnson
Copy link
Collaborator

I notice we use sudo pip install for these calls but no other pip install commands in the docs use sudo. Is there a reason for that or can we remove it?

@LiamConnors
Copy link
Member Author

Good question. Can't find a reason mentioned anywhere. @nicolaskruchten would you perhaps know?

@szhorvat
Copy link

Could this please be merged?

@LiamConnors
Copy link
Member Author

Sorry for the delay on this. I've created a new PR for this with just the required changes and we'll get it merged as soon as possible #4383

@LiamConnors LiamConnors deleted the igraph-update branch July 18, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants